[PATCH] D13814: Add support for SHF_MERGE sections

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 19 07:33:58 PDT 2015


rafael updated this revision to Diff 37753.
rafael added a comment.

I think this implements every review request except:

> Can you run two loops, one for regular sections and the other for merged sections, to improve readability? I don't like large loops.


There is substantial overlap on what the bodies would be.

And I have also not implemented the requested optimization. I will start coding it now. It can be committed with this patch or as an immediate followup. I would have a small preference of committing in as a followup.


http://reviews.llvm.org/D13814

Files:
  ELF/InputFiles.cpp
  ELF/InputFiles.h
  ELF/InputSection.cpp
  ELF/InputSection.h
  ELF/OutputSections.cpp
  ELF/OutputSections.h
  ELF/Symbols.h
  ELF/Writer.cpp
  test/elf2/Inputs/merge.s
  test/elf2/merge-invalid-size.s
  test/elf2/merge.s
  test/elf2/relocation-in-merge.s
  test/elf2/relocation-past-merge-end.s
  test/elf2/writable-merge.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13814.37753.patch
Type: text/x-patch
Size: 35379 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151019/909420ca/attachment.bin>


More information about the llvm-commits mailing list