[lld] r250555 - [ELF2] getLocalRelTarget should handle R_PPC64_TOC directly

[Hal Finkel via llvm-commits]

----- Original Message -----
> From: "Rafael Espíndola" <rafael.espindola at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "llvm-commits" <llvm-commits at lists.llvm.org>
> Sent: Friday, October 16, 2015 5:40:49 PM
> Subject: Re: [lld] r250555 - [ELF2] getLocalRelTarget should handle R_PPC64_TOC directly
> 
> > When why does the code in RelocationSection<ELFT>::writeTo have
> > this?
> >
> >   bool IsMips64EL = Relocs[0].C.getFile()->getObj().isMips64EL();
> >
> > I thought this might return a different result from
> > File.getObj().isMips64EL() [but then forgot to ask].
> 
> The code is there just to factor out IsMips64EL. The value will be
> the
> same for every reloc, so this puts the boring code out of the way.

Sure, but is IsMips64EL = Relocs[0].C.getFile()->getObj().isMips64EL() == File.getObj().isMips64EL() always true?

 -Hal

> 
> Cheers,
> Rafael
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory