[lld] r250555 - [ELF2] getLocalRelTarget should handle R_PPC64_TOC directly

[Hal Finkel via llvm-commits]

----- Original Message -----
> From: "Rui Ueyama" <ruiu at google.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "Rafael Espíndola" <rafael.espindola at gmail.com>, "llvm-commits" <llvm-commits at lists.llvm.org>
> Sent: Friday, October 16, 2015 5:29:18 PM
> Subject: Re: [lld] r250555 - [ELF2] getLocalRelTarget should handle R_PPC64_TOC directly
> 
> 
> PPC64 != MIPS, so you can always pass false, no?

Indeed :-)

Will do.

 -Hal

> 
> 
> On Fri, Oct 16, 2015 at 3:27 PM, Hal Finkel via llvm-commits <
> llvm-commits at lists.llvm.org > wrote:
> 
> 
> ----- Original Message -----
> > From: "Rafael Espíndola" < rafael.espindola at gmail.com >
> > To: "Hal Finkel" < hfinkel at anl.gov >
> > Cc: "llvm-commits" < llvm-commits at lists.llvm.org >
> > Sent: Friday, October 16, 2015 5:25:28 PM
> > Subject: Re: [lld] r250555 - [ELF2] getLocalRelTarget should handle
> > R_PPC64_TOC directly
> > 
> > >> You can get the type with
> > >> 
> > >> RI.getType(IsMips64EL)
> > >> 
> > >> Why the extra argument?
> > > 
> > > I either need to pass Type or IsMips64EL, right?
> > 
> > you can do
> > 
> > bool IsMips64EL = File.getObj().isMips64EL();
> 
> When why does the code in RelocationSection<ELFT>::writeTo have this?
> 
> bool IsMips64EL = Relocs[0].C.getFile()->getObj().isMips64EL();
> 
> I thought this might return a different result from
> File.getObj().isMips64EL() [but then forgot to ask].
> 
> > 
> > /me so wishes mips would fix their ELF variant.
> 
> :-)
> 
> -Hal
> 
> > 
> > Cheers,
> > Rafael
> > 
> 
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory