[PATCH] D13815: [ELF2] Add support for Gnu Hash section

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 15:11:36 PDT 2015


ruiu added inline comments.

================
Comment at: ELF/OutputSections.h:45-46
@@ -44,3 +44,4 @@
 
 bool includeInDynamicSymtab(const SymbolBody &B);
+bool includeInGnuHashTable(const SymbolBody &B);
 
----------------
I'm wondering if we really need two distinct functions for the traditional hash table and GNU's. GNU hash table is smaller than the traditional one because it omits some symbols. Technically, such symbols can be removed from the traditional hash table without hurting correctness.


http://reviews.llvm.org/D13815





More information about the llvm-commits mailing list