[PATCH] D13612: [IR] Add a `makeNoWrapRegion` method to `ConstantRange`

[Nick Lewycky via llvm-commits]

nlewycky added inline comments.

================
Comment at: include/llvm/IR/ConstantRange.h:91
@@ +90,3 @@
+  ///  makeNoWrapRegion(Add, i8 1, OBO::NoSignedWrap) == [-128, 127)
+  ///  makeNoWrapRegion(Add, i8 1, OBO::UnsignedWrap) == [0, -1)
+  ///  makeNoWrapRegion(Add, i8 0, OBO::NoUnsignedWrap) == Full Set
----------------
There is no OBO::UnsignedWrap??

================
Comment at: lib/IR/ConstantRange.cpp:139
@@ +138,3 @@
+  // not, of both X and Y).
+  auto PreciseIntersect =
+      [](const ConstantRange &CR0, const ConstantRange &CR1) {
----------------
ExclusiveIntersect? MinimalIntersect? SubsetIntersect? I don't feel like precise conveys meaning here (what's not precise about intersectWith? It's not about precision, it's about whether we choose to include all points in the intersection or choose to include only pointer in the intersection).


http://reviews.llvm.org/D13612