[llvm] r250222 - Tweak to r250117 and change to use ErrorOr and drop isSizeValid for

[Rafael Espíndola via llvm-commits]

On 13 October 2015 at 17:23, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
>> I didn’t know how far you wanted me to push this up the stack.  I can do that.  But there are lots of errors that are not handled well in libObject.
>
> Not handling an error is a bug.
>
> Ideally we want to push them up until we get out of lib, at which
> point we are in tools and can handle the error in whatever way is
> appropriate for that tool.
>
> But we can use report_fatal_error to move the error checking out one
> step at a time, but please never eat an error.

Ping. We are still eating the error and the test is still reverted.

Cheers,
Rafael