[PATCH] D13763: [lld][elf2] Sort allocated TLS sections at the start of the R/W PT_LOAD.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 12:30:29 PDT 2015


rafael added a comment.

Also please remove the "don't care" sections from the test:

.section v,"T", at nobits
.section u,"T"
section h,"aT", at nobits
.section f,"aT"

We only really care how we sort tls sections that are aw


================
Comment at: ELF/Writer.cpp:327
@@ -318,1 +326,3 @@
 
+  // The TLS initialization block needs to be a single contiguous block in a R/W
+  // PT_LOAD, so stick TLS sections directly before R/W sections. The TLS NOBITS
----------------
Move this past the comment

 // If we got here we know that both A and B are in the same PT_LOAD.


http://reviews.llvm.org/D13763





More information about the llvm-commits mailing list