[PATCH] D13792: Fix incorrect target triple in fp16-promote.ll

Vinicius Tinti via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 08:03:18 PDT 2015


On Fri, Oct 16, 2015 at 10:28 AM, Renato Golin <renato.golin at linaro.org> wrote:
> rengolin added a subscriber: rengolin.
> rengolin requested changes to this revision.
> rengolin added a reviewer: rengolin.
> rengolin added a comment.
> This revision now requires changes to proceed.
>
> Hi,
>
> This is weird, and I'd like to know more why the extra dash makes that big a difference...

It is due the "environment" parser. With only one dash the parser does
not recognize the "environment":

http://llvm.org/docs/doxygen/html/Triple_8cpp_source.html#l00441

Thus, subtarget->isTargetAnything() does not work.

> cheers,
> --renato
>
>
> http://reviews.llvm.org/D13792
>
>
>



-- 
Simplicity is the ultimate sophistication


More information about the llvm-commits mailing list