[PATCH] D13781: [sanitizer] Use same shadow offset for aarch64

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 06:05:11 PDT 2015


rengolin added a comment.

In http://reviews.llvm.org/D13781#268809, @zatrazz wrote:

> thus consume slight more memory in mapping (which is something I think we can live with).


When we proposed using the same mapping for both in January we were told that the memory increase was a real problem and that we should find a way that it could work best on both. That's why we started all this. :)

I'd like to have everyone agreeing that we can, indeed, live with it and finish this now. Last thing I want is to start a third round...

> That's not true, tsan can not be run with asan (trying to use -fsanitize=address,thread issues an error).


I stand corrected.

> You can have some

>  sanitizer working together, like asan and lsan, but it is due both use the same infrastructure.


But my question still stands: Won't all the other sanitizers break when run together with ASAN with this change?

I thought we had cross tests like that already, so maybe my question is answered already...

cheers,
--renato


http://reviews.llvm.org/D13781





More information about the llvm-commits mailing list