[PATCH] D13487: [Polly] Load/Store scalar accesses before/after the statement itself

[Michael Kruse via llvm-commits]

Meinersbur added inline comments.

================
Comment at: lib/CodeGen/BlockGenerators.cpp:1151
@@ -1127,1 +1150,3 @@
+               !DT.dominates(cast<Instruction>(Val)->getParent(), StmtExitBB))
+      continue;
 
----------------
I still see the failure. I will look tomorrow into it.

================
Comment at: test/Isl/CodeGen/non-affine-phi-node-expansion-3.ll:19-23
@@ -18,7 +18,7 @@
 ; CHECK-NEXT: %p_val1 = fadd float 1.000000e+00, 2.000000e+00
 ; CHECK-NEXT: %p_val2 = fadd float 1.000000e+00, 2.000000e+00
-; CHECK-NEXT: store float %p_val0, float* %merge.phiops
 ; CHECK-NEXT: %polly.subregion.iv.inc = add i32 %polly.subregion.iv, 1
+; CHECK-NEXT: store float %p_val0, float* %merge.phiops
 ; CHECK-NEXT: br i1
 
 branch1:
----------------
Mmmh, I looked for fixing the suspicious instructions in non-affine-phi-node-expansion-4.ll first without noticing they are gone with 250411 as well.


http://reviews.llvm.org/D13487