[PATCH] D13650: ARM/ELF: Better codegen for global variable addresses.

[Renato Golin via llvm-commits]

rengolin added a comment.

In http://reviews.llvm.org/D13650#268144, @pcc wrote:

> I believe that `test/CodeGen/ARM/load-global.ll` is a Thumb1 test case (it targets `thumbv6-linux-gnueabi`).


Hum, that could be, yes.

> While investigating this I found that fast ISel isn't even being used for Thumb{1,2} on ELF targets.


Ah, indeed! My mistake again. FastISel is disable in Thumb mode. Though, the original code had the alignment correct, so keeping is good. We don't want to make it worse.

> > I'm also concerned with potential edge cases, so if you could run the the test-suite on Thumb2 and ARM, that would be great.

> 

> 

> I'll see if I can get access to a machine to do this on, the only ones I have access to at the moment are Android devices.


I'll try to build it locally myself, too. I'll let you know as soon as I have something, so we don't duplicate efforts.

cheers,
--renato


http://reviews.llvm.org/D13650