[PATCH] D13606: [Introduction] Redundant load reduction with invariant intrinsics

Larisse Voufo via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 10:55:54 PDT 2015


lvoufo added a comment.

In http://reviews.llvm.org/D13606#267985, @dberlin wrote:

> I'm with Philip on this one.
>  This patch looks like it  can be split up.
>  As a rule, you don't have to make everything go at once, you can do it
>  piece by piece.
>
> (IE it's fine to modify one transform/analysis pass, even if nothing
>  but tests use it yet, and then add the use in a separate patch).
>
> More to the point, the feedback you are getting says: "If you want
>  this reviewed by reviewers, you should split it up more".
>  So unless you can point to concrete reasons it can't be split up, you
>  should do that.


Okay. Thanks for the clarifications. I'll see what I can do.


http://reviews.llvm.org/D13606





More information about the llvm-commits mailing list