[PATCH] D13753: Use Windows Vista API to get the user's home directory

[Paweł Bylica via llvm-commits]

chfast added inline comments.

================
Comment at: lib/Support/Windows/WindowsSupport.h:29-30
@@ -28,4 +28,4 @@
 
-// Require at least Windows XP(5.1) API.
-#define _WIN32_WINNT 0x0501
+// Require at least Windows Vista API.
+#define _WIN32_WINNT 0x0600
 #define _WIN32_IE    0x0600 // MinGW at it again.
----------------
aaron.ballman wrote:
> gbedwell wrote:
> > Please can you split this part off into its own change?  
> > 
> > I've had something similar on my TODO for far too long (sorry!), so I'm very happy to see this being done.  Given the previous discussion on Windows versions, I think we should jump straight to Windows 7 API here (we've already said we're doing that in the release notes), and ideally we might accompany this by a check/warning in CMake  as a courtesy although I don't feel too strongly about it.  I think a check based on ${CMAKE_SYSTEM_VERSION} should work.
> I agree that this should be changd to require at least Windows 7, and as a separate commit. You may also want to see whether we need to change _WIN32_IE as well while we're at it.
_WIN32_IE looks to be needed because mingw fails to define it basic on _WIN32_WINNT? I'm not able to verify that (happily haven't been using mingw for years). I will update it to the value matching Windows 7. 


Repository:
  rL LLVM

http://reviews.llvm.org/D13753