[PATCH] D13753: Use Windows Vista API to get the user's home directory

[Paweł Bylica via llvm-commits]

chfast added a comment.

In http://reviews.llvm.org/D13753#267883, @gbedwell wrote:

> My fear that it was still possible to build with the CMake option "-T vs120_xp" to specify an XP targeting platform toolset, but having just tried it to see whether it affects CMAKE_SYSTEM_VERSION or not, I've not actually been able to get that far without running into weird CMake errors so I'm not convinced that anyone would be able to use it anyway.  As I said, I don't feel too strongly about this.  It's been documented for a while that XP will no longer be supported and nobody leapt into the discussion to state that they still cared, so I don't think it's important to present a user friendly CMake-time error.  It would just be nice if it turned out to be trivial.


I've checked that. `-T "v120_xp"` option do not modify CMAKE_SYSTEM variables. The toolset option itself can by queried with CMAKE_GENERATOR_TOOLSET variable but only if was explicitly set. Considering all possible combination of options (MSVC, toolset, mingw32, mingw-w64) I would avoid detecting unsupported targeted Windows version in cmake script.


Repository:
  rL LLVM

http://reviews.llvm.org/D13753