[PATCH] D13753: Use Windows Vista API to get the user's home directory

[Greg Bedwell via llvm-commits]

gbedwell added inline comments.

================
Comment at: lib/Support/Windows/WindowsSupport.h:29-30
@@ -28,4 +28,4 @@
 
-// Require at least Windows XP(5.1) API.
-#define _WIN32_WINNT 0x0501
+// Require at least Windows Vista API.
+#define _WIN32_WINNT 0x0600
 #define _WIN32_IE    0x0600 // MinGW at it again.
----------------
Please can you split this part off into its own change?  

I've had something similar on my TODO for far too long (sorry!), so I'm very happy to see this being done.  Given the previous discussion on Windows versions, I think we should jump straight to Windows 7 API here (we've already said we're doing that in the release notes), and ideally we might accompany this by a check/warning in CMake  as a courtesy although I don't feel too strongly about it.  I think a check based on ${CMAKE_SYSTEM_VERSION} should work.


Repository:
  rL LLVM

http://reviews.llvm.org/D13753