[PATCH] D13690: Silence MSVC warning D9025 when /W3 present after /W4

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 19:29:42 PDT 2015


compnerd added inline comments.

================
Comment at: CMakeLists.txt:208
@@ -204,2 +207,3 @@
+  string(REGEX REPLACE " /W[0-4]" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
   append_string_if(COMPILER_RT_HAS_W3_FLAG /W3 CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
 else()
----------------
What happens if COMPILER_RT_HAS_W3_FLAG is set to false?  In this case, you've cleared out the flag but not re-appended it.  Or can that not occur?


http://reviews.llvm.org/D13690





More information about the llvm-commits mailing list