[PATCH] D8943: Calculate vectorization factor using the narrowest type instead of widest type

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 15:36:15 PDT 2015


spatel added a comment.

In http://reviews.llvm.org/D8943#267459, @congh wrote:

> Sorry for forgetting to clarify on this. After investigating those test results, I found that many large numbers are due to flaky tests. Many tests enjoying 5+% speed-up even don't have any change to be vectorized. However, I think your test results make more sense. So do you want me to do those tests again on my machine?


Ah...that matches my experience with test-suite then. :)
I just wanted to confirm that I wasn't missing some important step with test-suite or with your patch.
I don't see any value in running it all over again. However, for future changes, it would be good to know if your patch is firing on any of those tests, and if so, is there any perf difference? If not, we should locate some new tests!

Since the change is hidden behind a flag, I think this patch is fine. But I will let someone who knows the vectorizers better provide the final approval.


http://reviews.llvm.org/D8943





More information about the llvm-commits mailing list