[PATCH] D13687: [SCEV] Opportunistically interpret unsigned constraints as signed

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 14:55:59 PDT 2015


reames added a comment.

LGTM


================
Comment at: include/llvm/IR/InstrTypes.h:1035
@@ -1034,1 +1034,3 @@
 
+  /// For example, ULT->SLT, ULE->SLE, UGT->SGT, UGE->SGE, SLT->Failed assert
+  /// @returns the signed version of the unsigned predicate pred.
----------------
I believe we're moving away from this style of doxygen comment even when in code surrounded by similar.  the "/// brief. long" style has seemingly become the norm.  


http://reviews.llvm.org/D13687





More information about the llvm-commits mailing list