[PATCH] D13426: Move types in the LLVM C API from Core to Support

James Y Knight via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 07:39:03 PDT 2015


jyknight added a comment.

This seems sane to me. Of course, user code which said only:

  #include "llvm-c/BitReader.h"

and then depended upon getting the functions in llvm-c/Core.h transitively included will need to add a #include "llvm-c/Core.h", but that seems perfectly fine to me. My go-to examples of extremely stable libraries, glibc and libstdc++, make that kind of change all the time, for example.

Eric, do you object?


http://reviews.llvm.org/D13426





More information about the llvm-commits mailing list