[PATCH] D13724: Merge DAGCombiner::visitSREM and DAGCombiner::visitUREM (NFC)

[James Molloy via llvm-commits]

jmolloy added a subscriber: jmolloy.
jmolloy accepted this revision.
jmolloy added a reviewer: jmolloy.
jmolloy added a comment.
This revision is now accepted and ready to land.

Hi Artyom,

I agree that this factors out a significant chunk of code. LGTM apart from the single comment below.

Cheers,

James


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2350
@@ +2349,3 @@
+            DAG.getNode(ISD::ADD, DL, VT, N1,
+                   DAG.getConstant(APInt::getAllOnesValue(VT.getSizeInBits()),
+                                   DL, VT));
----------------
This looks like an unneeded/unintended change?


http://reviews.llvm.org/D13724