[LNT] r249026 - Add support for storing hash of test binaries.

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 14:49:33 PDT 2015


On 10/13/2015 11:39 PM, Kristof Beyls wrote:
> You're absolutely right in being annoyed and I apologize for the
> breakage. I would've reverted this, but the commit does include a
> change to the database schema and I'm afraid that reverting that
> change could cause people's database instances to get corrupted
> in the worst case.
>
> Thinking a bit more on how to get up-to-date clients to submit
> again to out-of-date servers: we could make the
> --exclude-stat-from-submission=hash
> the default value for now, until the llvm.org/perf server is updated.
> While this would help for working around the llvm.org/perf server issue,
> it would regress the functionality for people who run their own LNT servers,
> who will see that hash values will no longer be submitted to their servers
> which can process them.
>
> Putting everything in balance, I think it's a good idea in this
> instance to make this change until llvm.org/perf is upgraded; which
> would mean no clients/slaves would need to be changed and would avoid
> the buildbot master restart.

Thanks for your understanding. If you decide to commit this default 
change (which I think makes sense), feel free to revert my LNT buildbot
change and to inform Galina that a restart is not necessary any more.

Best,
Tobias



More information about the llvm-commits mailing list