[llvm] r250222 - Tweak to r250117 and change to use ErrorOr and drop isSizeValid for

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 14:23:01 PDT 2015


> I didn’t know how far you wanted me to push this up the stack.  I can do that.  But there are lots of errors that are not handled well in libObject.

Not handling an error is a bug.

Ideally we want to push them up until we get out of lib, at which
point we are in tools and can handle the error in whatever way is
appropriate for that tool.

But we can use report_fatal_error to move the error checking out one
step at a time, but please never eat an error.

Cheers,
Rafael


More information about the llvm-commits mailing list