[PATCH] D13666: Add an (optional) identification block in the bitcode

[Mehdi Amini via llvm-commits]

The problem is to be able to generate some invalid bitcode that *still contains the identification block*.

I tried with some valid bitcode: echo "randomstring" >> /tmp/bitcode.bc  ; 
But it is not enough to trigger an error with: llvm-dis /tmp/bitcode.bc 

— 
Mehdi


> On Oct 13, 2015, at 1:36 PM, Vedant Kumar <vsk at apple.com> wrote:
> 
> vsk added a subscriber: vsk.
> vsk added a comment.
> 
> Is it possible to add a test for this, perhaps by forcing bad bitcode into llvm-dis?
> 
>  $ llvm-as -disable-verify -o - | llvm-dis
>  define void @f() {
>    %1 = alloca i32
>    %1 = %1
>    ret void
>  }
>  llvm-as: <stdin>:3:8: error: expected instruction opcode
> 
> Seems like we could have a check-line here for the message BitcodeReader::error emits.
> 
> 
> http://reviews.llvm.org/D13666
> 
> 
>