[PATCH] D13645: [ELF2] - implemented default enterpteter for X86, X86_64, PPC and AArch64

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:70-72
@@ +69,5 @@
+  }
+  // No interpreter specified.
+  // Assumes that it is taken from commandline.
+  return "";
+}
----------------
  The empty string is not a valid value for .interp, so let's error out.

  error("--dynamic-linker is not specified");

================
Comment at: ELF/Driver.cpp:216-217
@@ -198,1 +215,4 @@
 
+  Config->DynamicLinker =
+      getString(Args, OPT_dynamic_linker, getDefaultInterp());
+
----------------
I'd write

  Config->DynamicLinker = getString(Args, OPT_dynamic_linker);
  if (Config->DynamicLinker.empty())
    Config->DynamicLinker = getDefaultInterp();

so that we don't call the function if --dynamic-linker is givne.


http://reviews.llvm.org/D13645