[PATCH] D13651: [ELF2] - Initial lazy loading support (x86_x64 and x86)

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 08:11:35 PDT 2015


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. This is a great feature. Thank you for doing this!


================
Comment at: test/elf2/plt-i686.s:23-35
@@ +22,15 @@
+// CHECK: Name: .got.plt
+// CHECK: Type: SHT_PROGBITS
+// CHECK: Flags [
+// CHECK:   SHF_ALLOC
+// CHECK:   SHF_WRITE
+// CHECK: ]
+// CHECK: Address: 0x12058
+// CHECK: Offset: 0x2058
+// CHECK: Size: 20
+// CHECK: Link: 0
+// CHECK: Info: 0
+// CHECK: AddressAlignment: 4
+// CHECK: EntrySize: 0
+// CHECK: }
+
----------------
You want to use CHECK-NEXT instead of CHECK.


http://reviews.llvm.org/D13651





More information about the llvm-commits mailing list