[PATCH] D13566: [ELF2] PPC64 needs to delay local-call relocations until after the function-descriptor values are known

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 14:51:38 PDT 2015


On Mon, Oct 12, 2015 at 2:34 PM, hfinkel at anl.gov <hfinkel at anl.gov> wrote:

> hfinkel added inline comments.
>
> ================
> Comment at: ELF/OutputSections.h:290-291
> @@ -289,2 +289,4 @@
>    static OutputSection<ELFT> *Bss;
> +  static OutputSection<ELFT> *Opd;
> +  static uint8_t *OpdBuf;
>    static PltSection<ELFT> *Plt;
> ----------------
> ruiu wrote:
> > Alright, I found that not look very good. How about adding these two
> fields to PPC64TargetInfo?
> I'll try that.
>
> FYI: PPC64, Itanium and HPPA seem to use the .opd section. Thus, while
> theoretically generic, I suspect we can consider this to be PPC64-specific
> in practice.


Agreed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151012/5ed5306f/attachment.html>


More information about the llvm-commits mailing list