[PATCH] D13668: [ELF2/LinkerScript] Fix OUTPUT_FORMAT directive parsing

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 14:02:42 PDT 2015


Thanks!

On Mon, Oct 12, 2015 at 2:01 PM, Rui Ueyama via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> ruiu accepted this revision.
> ruiu added a comment.
> This revision is now accepted and ready to land.
>
> LGTM with a nit.
>
>
> ================
> Comment at: ELF/LinkerScript.cpp:214-215
> @@ -213,1 +213,4 @@
>    expect("(");
> +  StringRef Tok = next();
> +  Tok = next();
> +  if (Tok == ")")
> ----------------
> Please discard the result first next() and assign only the second one.
>
>
> http://reviews.llvm.org/D13668
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list