[lld] r250087 - [ELF2/PPC64] Add a comment about the page size

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 12:34:29 PDT 2015


Author: hfinkel
Date: Mon Oct 12 14:34:29 2015
New Revision: 250087

URL: http://llvm.org/viewvc/llvm-project?rev=250087&view=rev
Log:
[ELF2/PPC64] Add a comment about the page size

Rafael requested some additional commentary (post-commit review of r249760), to
make it clear this is intended and necessary.

Modified:
    lld/trunk/ELF/Target.cpp

Modified: lld/trunk/ELF/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=250087&r1=250086&r2=250087&view=diff
==============================================================================
--- lld/trunk/ELF/Target.cpp (original)
+++ lld/trunk/ELF/Target.cpp Mon Oct 12 14:34:29 2015
@@ -200,7 +200,11 @@ PPC64TargetInfo::PPC64TargetInfo() {
   // PCRelReloc = FIXME
   // GotReloc = FIXME
   PltEntrySize = 32;
+
+  // We need 64K pages (at least under glibc/Linux, the loader won't
+  // set different permissions on a finer granularity than that).
   PageSize = 65536;
+
   VAStart = 0x10000000;
 }
 void PPC64TargetInfo::writePltEntry(uint8_t *Buf, uint64_t GotEntryAddr,




More information about the llvm-commits mailing list