[PATCH] D13566: [ELF2] PPC64 needs to delay local-call relocations until after the function-descriptor values are known

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:43-50
@@ -42,2 +42,10 @@
 template <> OutputSection<ELF64LE> *Out<ELF64LE>::Bss = nullptr;
+template <> OutputSection<ELF32BE> *Out<ELF32BE>::Opd = nullptr;
+template <> OutputSection<ELF32LE> *Out<ELF32LE>::Opd = nullptr;
+template <> OutputSection<ELF64BE> *Out<ELF64BE>::Opd = nullptr;
+template <> OutputSection<ELF64LE> *Out<ELF64LE>::Opd = nullptr;
+template <> uint8_t *Out<ELF32BE>::OpdBuf = nullptr;
+template <> uint8_t *Out<ELF32LE>::OpdBuf = nullptr;
+template <> uint8_t *Out<ELF64BE>::OpdBuf = nullptr;
+template <> uint8_t *Out<ELF64LE>::OpdBuf = nullptr;
 template <> PltSection<ELF32BE> *Out<ELF32BE>::Plt = nullptr;
----------------
Please rebase to head.

================
Comment at: ELF/OutputSections.h:290-291
@@ -289,2 +289,4 @@
   static OutputSection<ELFT> *Bss;
+  static OutputSection<ELFT> *Opd;
+  static uint8_t *OpdBuf;
   static PltSection<ELFT> *Plt;
----------------
Alright, I found that not look very good. How about adding these two fields to PPC64TargetInfo?


http://reviews.llvm.org/D13566