[PATCH] D13121: Improve ISel across lane float min/max reduction

[Jun Bum Lim via llvm-commits]

Thanks Charlie for finding this bug. I will fix it immediately!

-----Original Message-----
From: Charlie Turner [mailto:charlie.turner at arm.com] 
Sent: Monday, October 12, 2015 8:22 AM
To: junbuml at codeaurora.org; mcrosier at codeaurora.org; james.molloy at arm.com
Cc: charlie.turner at arm.com; llvm-commits at lists.llvm.org; amara.emerson at arm.com
Subject: Re: [PATCH] D13121: Improve ISel across lane float min/max reduction

chatur01 added a subscriber: chatur01.
chatur01 added a comment.

Hi Jun, I've just got around to looking at this, and you need to update the test names, please see below.


================
Comment at: test/CodeGen/AArch64/aarch64-minmaxv.ll:289-291
@@ +288,5 @@
+
+; CHECK-LABEL: f_fmaxnmv
+; CHECK: fmaxnmv
+define float @f_fmaxnmv(<4 x float>* nocapture readonly %arr) {
+  %rdx.minmax.select  = load <4 x float>, <4 x float>* %arr
----------------
Need to rename this test, the function body can be anything and this test will pass. I've been caught out before naming a function the same as an instruction I'm looking for. The `CHECK: fmaxmv` will actually match the label in this case.

================
Comment at: test/CodeGen/AArch64/aarch64-minmaxv.ll:305-307
@@ +304,5 @@
+
+; CHECK-LABEL: f_fminnmv
+; CHECK: fminnmv
+define float @f_fminnmv(<4 x float>* nocapture readonly %arr) {
+  %rdx.minmax.select  = load <4 x float>, <4 x float>* %arr
----------------
Same as above, please change the test name.


http://reviews.llvm.org/D13121