[lld] r249965 - ELF2: Simplify. NFC.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 11 12:49:12 PDT 2015


Done in r249992. I personally prefer the original format than
clang-format's format for this code (so I wrote that way), but that's
probably an argument we'd like to avoid just by using clang-format, so the
new code is ok with me.

On Sun, Oct 11, 2015 at 12:34 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> > +#include <utility>
>
> This is not being used.
>
>
> > +static std::pair<ELFKind, uint16_t> parseEmulation(StringRef S) {
> > +  if (S == "elf32btsmip") return {ELF32BEKind, EM_MIPS};
> > +  if (S == "elf32ltsmip") return {ELF32LEKind, EM_MIPS};
> > +  if (S == "elf32ppc")    return {ELF32BEKind, EM_PPC};
> > +  if (S == "elf64ppc")    return {ELF64BEKind, EM_PPC64};
> > +  if (S == "elf_i386")    return {ELF32LEKind, EM_386};
> > +  if (S == "elf_x86_64")  return {ELF64LEKind, EM_X86_64};
> > +  error("Unknown emulation: " + S);
> >  }
>
> Please git-clang-format the patch.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151011/96002379/attachment.html>


More information about the llvm-commits mailing list