[PATCH] D13637: ELF2: Fix BSD's __progname symbol issue.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 11 11:58:24 PDT 2015


I was trying to write the comment concretely to help readers understand the
problem, but that may read that the issue would be limited to __progname.
I'll update the comment. Thank you for the advice.

On Sun, Oct 11, 2015 at 11:53 AM, Joerg Sonnenberger <
joerg at britannica.bec.de> wrote:

> On Sun, Oct 11, 2015 at 11:39:24AM -0700, Rui Ueyama via llvm-commits
> wrote:
> > Why COPY relocation is related to this?
>
> Sorry, mixed up the cases slightly. No COPY is needed, but the comments
> can stop talking about the specific __progname case. libwrap and
> allow_severity is the classic example. Some systems now patch it to
> provide a weak definition, but that's also worth check for. E.g. if a
> symbol is strongly defined in the main program and all DSOs have only a
> weak version, the symbol also needs to be exported.
>
> Joerg
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151011/7c2f6e8a/attachment.html>


More information about the llvm-commits mailing list