[lld] r249955 - ELF2: Remove ProgramHeader class and use Elf_Phdr directly. NFC.

[Rui Ueyama via llvm-commits]

On Sun, Oct 11, 2015 at 7:30 AM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 11 October 2015 at 10:24, Rui Ueyama <ruiu at google.com> wrote:
> > Sorry about the style change. I'll separate them in future.
> >
> > I think the use of unordered_set is reasonable because the number of
> > segments are very small.
>
> That is precisely why it is not reasonable :-)
>
> Playing with the code a bit it seems the best thing is to just replace
> it with at SmallPtrSet.
>

I'm not objecting to use SmallPtrSet, and that's probably good because it
wouldn't raise this kind of discussion and also hint to the reader that the
set is, well, a set of small pointers. But thinking about the function is
called only once and the set is probably looked up less than 100 times, I'd
still call it reasonable (at least is not unreasonable). :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151011/b679ce3f/attachment-0001.html>