[PATCH] D13591: [mips] Clean up most macro expansions to use the emit*() functions.

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 13:55:28 PDT 2015


vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2794-2795
@@ +2793,4 @@
+
+  emitRRX(IsLikely ? AcceptsEquality ? Mips::BEQL : Mips::BNEL
+                   : AcceptsEquality ? Mips::BEQ : Mips::BNE,
+          ATRegNum, Mips::ZERO, MCOperand::createExpr(OffsetExpr), IDLoc,
----------------
We should parenthesize the nested ternary operators.


http://reviews.llvm.org/D13591





More information about the llvm-commits mailing list