[PATCH] D13598: Add comdat support.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 10:46:15 PDT 2015


ruiu added a comment.

I'm not in favor of the optimization you made by merging two hash tables, one for group merging and the other for regular symbols, into one hash table using tagged pointer. I'd really want to simply use StringSet for group dedup'ing and keep the symbol table as is.

Except that the patch looks good overall.


Repository:
  rL LLVM

http://reviews.llvm.org/D13598





More information about the llvm-commits mailing list