[llvm] r249852 - AArch64: Make getNextNode() cleanup in r249764 more clear

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 09:54:54 PDT 2015


Author: dexonsmith
Date: Fri Oct  9 11:54:54 2015
New Revision: 249852

URL: http://llvm.org/viewvc/llvm-project?rev=249852&view=rev
Log:
AArch64: Make getNextNode() cleanup in r249764 more clear

After r249764, if you didn't see the full context, it looked like
`std::next(I)` would get the same result as
`++MachineBasicBlock::iterator(I)`.  However, `I` is a `MachineInstr*`
(not a `MachineBasicBlock::iterator`).

Use the `getIterator()` helper I added later (r249782) to make this code
more clear.

Modified:
    llvm/trunk/lib/Target/AArch64/AArch64CleanupLocalDynamicTLSPass.cpp

Modified: llvm/trunk/lib/Target/AArch64/AArch64CleanupLocalDynamicTLSPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64CleanupLocalDynamicTLSPass.cpp?rev=249852&r1=249851&r2=249852&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64CleanupLocalDynamicTLSPass.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64CleanupLocalDynamicTLSPass.cpp Fri Oct  9 11:54:54 2015
@@ -118,8 +118,8 @@ struct LDTLSCleanup : public MachineFunc
 
     // Insert a copy from X0 to TLSBaseAddrReg for later.
     MachineInstr *Copy =
-        BuildMI(*I->getParent(), ++MachineBasicBlock::iterator(I),
-                I->getDebugLoc(), TII->get(TargetOpcode::COPY), *TLSBaseAddrReg)
+        BuildMI(*I->getParent(), ++I->getIterator(), I->getDebugLoc(),
+                TII->get(TargetOpcode::COPY), *TLSBaseAddrReg)
             .addReg(AArch64::X0);
 
     return Copy;




More information about the llvm-commits mailing list