[PATCH] D13455: [safestack] Fast access to the unsafe stack pointer on AArch64/Android.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/CodeGen/TargetLoweringBase.cpp:1677
@@ +1676,3 @@
+    // thread-local variable with a magic name.
+    const char *kUnsafeStackPtrVar = "__safestack_unsafe_stack_ptr";
+    auto UnsafeStackPtr =
----------------
echristo wrote:
> Naming, and you can just fold it in as well.
It's used in 4 places. Fixed the naming.

================
Comment at: lib/Target/AArch64/AArch64Subtarget.h:126-128
@@ -125,2 +125,5 @@
   bool isTargetWindows() const { return TargetTriple.isOSWindows(); }
+  bool isTargetAndroid() const {
+    return TargetTriple.getEnvironment() == Triple::Android;
+  }
 
----------------
echristo wrote:
> Given how pervasive this is now, it'll probably be worth splitting this out into a separate commit and doing a look for Triple.isAndroid() and updating all of the callers in llvm and clang.
Done and rebased.



Repository:
  rL LLVM

http://reviews.llvm.org/D13455