[PATCH] D13571: Add Triple::isAndroid().

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 13:56:11 PDT 2015


Only minor bike shedding:

isEnvAndroid/isEnvironmentAndroid rather than just isAndroid to match the
rest of the naming scheme?

Otherwise LGTM.

-eric

On Thu, Oct 8, 2015 at 1:53 PM Stephen Hines <srhines at google.com> wrote:

> srhines added a comment.
>
> LGTM. Thanks for adding this. I know that it will make a lot of other
> folks happy within Android too, that this will be more easily accessible.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D13571
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151008/581cb72d/attachment.html>


More information about the llvm-commits mailing list