[PATCH] D13222: [ValueTracking] teach computeKnownBits that a fabs() clears sign bits

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 12:45:38 PDT 2015


arsenm added a comment.

In http://reviews.llvm.org/D13222#263109, @spatel wrote:

> In http://reviews.llvm.org/D13222#263038, @arsenm wrote:
>
> > Should this also be done in DAGCombiner?
>
>
> Sure - I would think that anything that's being done in ValueTracking should be done there too. Can this be refactored, so we're not duplicating code?


Not really. The IR and DAG APIs are pretty different. All of this similar logic is already duplicated


Repository:
  rL LLVM

http://reviews.llvm.org/D13222





More information about the llvm-commits mailing list