[PATCH] D13517: ValueTracking: use getAlignment in isAligned

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 10:04:27 PDT 2015


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM.  Thanks for separating; this is obvious standalone, but I was getting it confused in the last patch.


================
Comment at: lib/Analysis/ValueTracking.cpp:3002
@@ -3001,3 +2988,3 @@
 
   if (!BaseAlign) {
     Type *Ty = Base->getType()->getPointerElementType();
----------------
Could this check be moved inside getAlignment?  If so, that might be a good follow on change?


http://reviews.llvm.org/D13517





More information about the llvm-commits mailing list