[PATCH] D13530: [Polly][WIP] Remove the dimensions from the MemoryAccess

[Michael Kruse via llvm-commits]

Meinersbur added a comment.

This patch seems to do a bit more than just make MemoryAccess use the dimension sizes from ScopArrayInfo (e.g. making the global InsnToMemAcc a member field). Those should be described in the commit message and/or put into different patches.

Accessing private members of DetectionContext from ScopInfo seems like a layer violation. DetectionContext is something ScopDetection uses internally and i.e. maybe shouldn't be exposed to other classes.

Otherwise some really good changes++


================
Comment at: include/polly/ScopInfo.h:1124
@@ -1145,2 +1123,3 @@
   /// @brief Initialize this ScopInfo .
-  void init(AliasAnalysis &AA);
+  void
+  init(AliasAnalysis &AA,
----------------
Parameter description

================
Comment at: lib/Analysis/ScopInfo.cpp:1514
@@ +1513,3 @@
+
+    auto *SAI =
+        createScopArrayInfo(BasePtr, ArrayType->getPointerElementType());
----------------
auto not necessary

================
Comment at: lib/Analysis/ScopInfo.cpp:3174
@@ -3173,3 +3214,1 @@
 
-extern MapInsnToMemAcc InsnToMemAcc;
-
----------------
I am really glad that this global variable goes away

================
Comment at: lib/Analysis/ScopInfo.cpp:3283
@@ -3282,3 @@
-  const SCEV *SizeSCEV =
-      SE->getConstant(TD->getIntPtrType(Inst->getContext()), Size);
-
----------------
++

================
Comment at: test/ScopInfo/delinearize-together-all-data-refs.ll:14
@@ -13,3 +13,3 @@
 ; CHECK: Arrays {
-; CHECK:     double MemRef_A[*][%m][%o][8] // Element size 8
+; CHECK:     double MemRef_A[*][%m][%o] // Element size 8
 ; CHECK: }
----------------
Can you explain why this changes? The commit message makes the impression that it is an internal reorganization only.


http://reviews.llvm.org/D13530