[PATCH] D13542: [ELF2/LinkerScript] Support for SEARCH_DIR() directive

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: test/elf2/linkerscript.s:26
@@ -25,1 +25,3 @@
 
+# RUN: echo "SEARCH_DIR(\"/lib/foo/blah\")" > %t.script
+# RUN: ld.lld2 %t.script %t
----------------
ruiu wrote:
> You don't unquote and quote here because /lib/foo/blah does not contain any variables unlike others.
> 
>   echo "SEARCH_DIR(/lib/foo/blah)" > %t.script
> 
Noticed that I misunderstood this test. Its testing double-quoted path name. Linker script doesn't distinguish them, so either

  echo "SEARCH_DIR(/lib/foo/blah)" > %t.script

or

  echo 'SEARCH_DIR("/lib/foo/blah")' > %t.script

is fine with me. This is not a test for the tokenizer after all. I'd just avoid using double quotes inside double quotes.


http://reviews.llvm.org/D13542