[PATCH] D13542: [ELF2/LinkerScript] Support for SEARCH_DIR() directive

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: ELF/LinkerScript.cpp:169-170
@@ +168,4 @@
+  expect("(");
+  StringRef Tok = next();
+  Config->InputSearchPaths.push_back(Tok);
+  expect(")");
----------------
  Config->InputSearchPaths.push_back(next());

================
Comment at: test/elf2/linkerscript.s:26
@@ -25,1 +25,3 @@
 
+# RUN: echo "SEARCH_DIR(\"/lib/foo/blah\")" > %t.script
+# RUN: ld.lld2 %t.script %t
----------------
You don't unquote and quote here because /lib/foo/blah does not contain any variables unlike others.

  echo "SEARCH_DIR(/lib/foo/blah)" > %t.script



http://reviews.llvm.org/D13542