[PATCH] D13188: [MachO] Stop generating *coal* sections.

[Jim Grosbach via llvm-commits]

grosbach added a comment.

The idea seems fine. The implementation is off, though. Why are we re-mapping the section names after the fact instead of setting them correctly in the first place? The call to setMachOCoalSections() is already even being added in exactly the same function which would need to be modified for that.

Something like:

bool useCoalSections = ArchTy != Triple::ppc && ArchTy != Triple::ppc64;
const char *TextCoalSectionName = useCoalSections ? "__textcoal_nt" : "__text";
...

  TextCoalSection                                                                
    = Ctx->getMachOSection("__TEXT", TextCoalSectionName,                            
                           MachO::S_COALESCED |                                  
                           MachO::S_ATTR_PURE_INSTRUCTIONS,                      
                           SectionKind::getText()); 


http://reviews.llvm.org/D13188