[PATCH] D13432: cmake: Avoid leading space in LLVM_DEFINITIONS.

[Chris Bieneman via llvm-commits]

beanz added a subscriber: beanz.
beanz added a comment.

I haven't tested it yet, but I suspect something like this would work by treating LLVM_DEFINITONS as a list:

  diff --git a/cmake/modules/AddLLVMDefinitions.cmake b/cmake/modules/AddLLVMDefinitions.cmake
  index 33ac973..c4d3cc8 100644
  --- a/cmake/modules/AddLLVMDefinitions.cmake
  +++ b/cmake/modules/AddLLVMDefinitions.cmake
  @@ -6,8 +6,6 @@
   
   macro(add_llvm_definitions)
     # We don't want no semicolons on LLVM_DEFINITIONS:
  -  foreach(arg ${ARGN})
  -    set(LLVM_DEFINITIONS "${LLVM_DEFINITIONS} ${arg}")
  -  endforeach(arg)
  +  list(APPEND LLVM_DEFINITIONS ${ARGN})
     add_definitions( ${ARGN} )
   endmacro(add_llvm_definitions)
  diff --git a/cmake/modules/LLVMConfig.cmake.in b/cmake/modules/LLVMConfig.cmake.in
  index 6855c44..a71d8d8 100644
  --- a/cmake/modules/LLVMConfig.cmake.in
  +++ b/cmake/modules/LLVMConfig.cmake.in
  @@ -49,7 +49,7 @@ set(LLVM_LIBDIR_SUFFIX @LLVM_LIBDIR_SUFFIX@)
   
   set(LLVM_INCLUDE_DIRS "@LLVM_CONFIG_INCLUDE_DIRS@")
   set(LLVM_LIBRARY_DIRS "@LLVM_CONFIG_LIBRARY_DIRS@")
  -set(LLVM_DEFINITIONS "@LLVM_DEFINITIONS@")
  +set(LLVM_DEFINITIONS @LLVM_DEFINITIONS@)
   set(LLVM_CMAKE_DIR "@LLVM_CONFIG_CMAKE_DIR@")
   set(LLVM_TOOLS_BINARY_DIR "@LLVM_CONFIG_TOOLS_BINARY_DIR@")




http://reviews.llvm.org/D13432