[PATCH] D10717: Enhance loop rotation with existence of profile data in MachineBlockPlacement pass.

[Daniel Jasper via llvm-commits]

djasper added a comment.

Just a minor comment about the wording of the options. Otherwise, I don't think I'll add much to the reviews by both Chandler and David.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:93
@@ +92,3 @@
+    cl::desc("Cost that models the probabalistic risk of an instruction "
+             "misfetch due to a jump relative to falling through."),
+    cl::init(1), cl::Hidden);
----------------
In what way is the cost "relative"?

In my understanding, this can either mean that it is a difference or a ratio. In either case "unsigned" would be a weird data type.

================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:99
@@ +98,3 @@
+    cl::desc(
+        "Relative cost of jump instructions comparing to cost of misfethch."),
+    cl::init(1), cl::Hidden);
----------------
Same as above, what do you actually mean by "relative"?




http://reviews.llvm.org/D10717