[PATCH] D13452: [asan] On OS X, log reports to syslog and os_trace (version 2)

[Anna Zaks via llvm-commits]

zaks.anna added inline comments.

================
Comment at: lib/asan/asan_report.cc:674
@@ +673,3 @@
+    error_message_buf_mutex.Lock();
+    LogFullErrorReport(error_message_buffer);
+
----------------
zaks.anna wrote:
> samsonov wrote:
> > You can just add a scope and BlockingMutexLock here.
> Report calls Print, which might call AppendToErrorMessageBuffer resulting in double locking.
Oh, "add a scope". OK. Will do.


http://reviews.llvm.org/D13452