[PATCH] D13188: [MachO] Stop generating *coal* sections.

Akira Hatanaka via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 16:29:56 PDT 2015


ahatanak added a comment.

But you would still want to call the destructors (either explicitly or implicitly) of MCSection subclasses, right? If we don't run the destructors, we'll be leaking MCSection::SubsectionFragmentMap, even if we make changes to use BumpPtrAllocator for MCSection::Fragments.

If you are worried about the overhead of using shared_ptr, I think we can continue using raw pointers and add checks that prevent the destructor from being run twice, although I'm not sure that would be a good idea.


http://reviews.llvm.org/D13188





More information about the llvm-commits mailing list