[PATCH] D13378: [SCEV] Recognize simple br-phi patterns

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 10:52:55 PDT 2015



Diego Novillo wrote:
>
>
> On Tue, Oct 6, 2015 at 1:48 PM, Sanjoy Das <sanjoy at playingwithpointers.com <mailto:sanjoy at playingwithpointers.com>> wrote:
>
>
>
>     Diego Novillo via llvm-commits wrote:
>
>         dnovillo added a subscriber: dnovillo.
>         dnovillo added a comment.
>
>         Sanjoy,
>
>         This commit is causing an internal compiler error with the following code:
>
>         int x0, x1, x2;
>         double *x3;
>         int fsolv() {
>
>             int x4, x5 = x4 = 0;
>             for (; x4<  x2; ++x4) {
>               x0 = 0;
>               for (; x0<  x4; ++x0)
>                 x1 = x3[x5++];
>             }
>             return 0;
>
>         }
>
>         Is this something you recognize?  If not, do you mind if I revert your
>         commit while you work on the test case?
>
>
>     It is plausible that this is the same issue as in http://reviews.llvm.org/D13460.  If it is possible, can you please
>     try D13460 and see if it fixes the ICE?  If not or if trying out a new patch will be too much work, reverting this
>     is okay.
>
>
> I'm now testing r249431 which supposedly fixes this ICE.  I'll know in a few minutes.

If you're going by "<jokereph_> dnovillo: I just commited r249431 based on sanjoyd commit, you’ll have to revert this 
one first." on IRC, I think what he meant was that 249431 builds on the br-phi change, not that it fixes the ICE. :)

-- Sanjoy


>
> Thanks. Diego.


More information about the llvm-commits mailing list