[PATCH] D13432: cmake: Avoid leading space in LLVM_DEFINITIONS.

[Johannes S. Mueller-Roemer via llvm-commits]

jsroemer added a subscriber: jsroemer.
jsroemer added a comment.

In http://reviews.llvm.org/D13432#260571, @chfast wrote:

> Alternative solution is to keep LLVM_DEFINITIONS as a cmake lists (; separated values). And convert it into the flags string on demand. E.g. with a helper function like llvm_get_definitions.


That should be the preferred solution, as this matches both the correct use of add_definitions and target_compile_definitions.

Also, have you considered replacing add_llvm_definitions by proper use of target_compile_definitions? That would make LLVM_DEFINITONS unnecessary.


http://reviews.llvm.org/D13432